| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | chenhj <chjischj(at)163(dot)com>, David Rowley <david(dot)rowley(at)2ndquadrant(dot)com>, Andres Freund <andres(at)anarazel(dot)de>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH:do not set Win32 server-side socket buffer size on windows 2012 |
| Date: | 2015-07-06 14:06:17 |
| Message-ID: | 559A8B59.6040103@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 07/06/2015 04:30 PM, Tom Lane wrote:
> Heikki Linnakangas <hlinnaka(at)iki(dot)fi> writes:
>> I was able to reproduce huge gains from this, after I introduced an
>> artificial latency to all network packets with:
>
>> tc qdisc add dev eth2 root netem delay 100ms
>
>> With that, and with the client on different host so that the traffic
>> goes through that high-latency network, I saw over 10x difference with
>> the same psql test you ran.
>
>> Committed, thanks!
>
> Why does the committed patch do getsockopt() on server_fd rather than
> port->sock? This seems at best confusing and at worst wrong.
Good catch, fixed!
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-07-06 14:07:42 | Re: Inconsistent style in pgbench's error messages |
| Previous Message | Stephen Frost | 2015-07-06 14:04:37 | Re: Idea: closing the loop for "pg_ctl reload" |