| From: | Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Remove win32ver.rc from version_stamp.pl |
| Date: | 2020-03-09 07:43:25 |
| Message-ID: | 5599e5cb-7d07-c4fc-24f9-273c4b7a2eec@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 2020-03-01 23:51, Tom Lane wrote:
> In general, while I'm on board with the idea, I wonder whether it
> wouldn't be smarter to keep on defining PG_MAJORVERSION as a string,
> and just add PG_MAJORVERSION_NUM alongside of it. This would
> eliminate some hunks from the patch in places where it's more
> convenient to have the version as a string, and it would avoid
> what could otherwise be a pretty painful cross-version incompatibility
> for extensions. We already provide PG_VERSION in both forms, so
> I don't see any inconsistency in doing likewise for PG_MAJORVERSION.
Agreed. Here is another patch.
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| Attachment | Content-Type | Size |
|---|---|---|
| v2-0001-Remove-win32ver.rc-from-version_stamp.pl.patch | text/plain | 8.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-03-09 07:47:27 | Re: Add an optional timeout clause to isolationtester step. |
| Previous Message | Julien Rouhaud | 2020-03-09 07:04:27 | Re: reindex concurrently and two toast indexes |