Re: [PATCH] Generalized JSON output functions

On 07/03/2015 06:27 AM, Heikki Linnakangas wrote:
> On 05/27/2015 09:51 PM, Andrew Dunstan wrote:
>>
>> On 05/27/2015 02:37 PM, Robert Haas wrote:
>>> On Tue, May 26, 2015 at 2:50 AM, Shulgin, Oleksandr
>>> <oleksandr(dot)shulgin(at)zalando(dot)de> wrote:
>>>> Is it reasonable to add this patch to CommitFest now?
>>> It's always reasonable to add a patch to the CommitFest if you would
>>> like for it to be reviewed and avoid having it get forgotten about.
>>> There seems to be some disagreement about whether we want this, but
>>> don't let that stop you from adding it to the next CommitFest.
>>
>> I'm not dead set against it either. When I have time I will take a
>> closer look.
>
> Andrew, will you have the time to review this? Please add yourself as
> reviewer in the commitfest app if you do.
>
> My 2 cents is that I agree with your initial reaction: This is a lot
> of infrastructure and generalizing things, for little benefit. Let's
> change the current code where we generate JSON to be consistent with
> whitespace, and call it a day.
>
> - Heikki
>

I'm somewhat on vacation for the next week or so, so I won't claim it,
but I'll try to make time to look at it. Other people (Merlin?) could
also provide reviews.

cheers

andrew