| From: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> |
|---|---|
| To: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it>, <pgsql-bugs(at)postgresql(dot)org>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [HACKERS] BUG #13473: VACUUM FREEZE mistakenly cancel standby sessions |
| Date: | 2015-06-26 23:13:31 |
| Message-ID: | 558DDC9B.6090001@BlueTreble.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-bugs pgsql-hackers |
On 6/26/15 8:50 AM, Marco Nenciarini wrote:
>> >In the heap_xlog_freeze we need to subtract one to the value of cutoff_xid
>> >before passing it to ResolveRecoveryConflictWithSnapshot.
>> >
>> >
>> >
> Attached a proposed patch that solves the issue.
FWIW, I've reviewed the usage and the new logic looks correct.
It'd actually be nice if we also logged the most recent XID that
actually got frozen. That's the XID that Hot Standby would actually care
about (not the freeze limit).
--
Jim Nasby, Data Architect, Blue Treble Consulting, Austin TX
Data in Trouble? Get it in Treble! http://BlueTreble.com
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Petr Jelinek | 2015-06-27 02:27:07 | Re: sampling.c and potential divisions by 0 ang log(0) with tablesample and ANALYZE in 9.5 |
| Previous Message | Michael Paquier | 2015-06-26 23:03:07 | Re: Incorrect processing of CREATE TRANSFORM with DDL deparding |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tomas Vondra | 2015-06-27 00:16:02 | Re: pg_stat_*_columns? |
| Previous Message | Simon Riggs | 2015-06-26 22:47:48 | Re: UPSERT on partition |