Re: A couple of newlines missing in pg_rewind log entries

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: A couple of newlines missing in pg_rewind log entries
Date: 2015-06-23 12:53:31
Message-ID: 558956CB.4070606@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/23/2015 07:39 AM, Michael Paquier wrote:
> Hi all,
>
> Some grepping is showing up that a couple of newlines are missing in
> pg_rewind, leading to unreadable log entries:
> libpq_fetch.c: pg_log(PG_DEBUG, "getting file chunks");

Fixed.

> logging.c: pg_log(PG_PROGRESS, "%*s/%s kB (%d%%) copied",

This one was on purpose; note the printf("\r") after that line. That's
supposed to be a progress indicator that is updated on the single line.

> filemap.c: pg_fatal("could not stat file \"%s\": %s",

Peter fixed this already.

- Heikki

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Abhijit Menon-Sen 2015-06-23 13:09:10 Re: [PATCH] introduce XLogLockBlockRangeForCleanup()
Previous Message Heikki Linnakangas 2015-06-23 12:19:00 Re: pg_rewind failure by file deletion in source server