Re: Re: [PATCH][PROPOSAL] Add enum releation option type

From: David Steele <david(at)pgmasters(dot)net>
To: Nikolay Shaplov <dhyan(at)nataraj(dot)su>, pgsql-hackers(at)lists(dot)postgresql(dot)org
Cc: Michael Paquier <michael(at)paquier(dot)xyz>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Robert Haas <robertmhaas(at)gmail(dot)com>, Nikita Glukhov <n(dot)gluhov(at)postgrespro(dot)ru>, "pgsql-hackers(at)postgresql(dot)org" <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Re: [PATCH][PROPOSAL] Add enum releation option type
Date: 2019-03-25 08:39:01
Message-ID: 55872b5a-a5db-8c99-4885-8d976c644a1d@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 3/18/19 11:54 PM, Nikolay Shaplov wrote:
> В письме от среда, 20 февраля 2019 г. 15:08:32 MSK пользователь Michael
> Paquier написал:
>
>>> 2.5 May be this src/test/modules dummy index is subject to another patch.
>>> So I will start working on it right now, but we will do this work not
>>> dependent to any other patches. And just add there what we need when it
>>> is ready. I would actually add there some code that checks all types of
>>> options, because we actually never check that option value from reloptons
>>> successfully reaches extension code. I did this checks manually, when I
>>> wrote that bigger reloption patch, but there is no facilities to do
>>> regularly check is via test suit. Creating dummy index will create such
>>> facilities.
>>
>> bloom is a user-facing extension, while src/test/modules are normally
>> not installed (there is an exception for MSVC anyway..), so stressing
>> add_enum_reloption in src/test/modules looks more appropriate to me,
>> except if you can define an option which is useful for the user and is
>> an enum.
> I've created a module in src/test/modules where we would be able to add enum
> support when that module is commited.
>
> https://commitfest.postgresql.org/23/2064/
>
> I've filed it as a separate patch (it is standalone work as I can feel it).
> Sadly I did not manage to prepare it before this commitfest, so I've added it
> to a next one. :-((

It's not clear to me that all of Michael's and Álvaro's issues have been
addressed, so I've marked this Waiting on Author.

Regards,
--
-David
david(at)pgmasters(dot)net

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message David Steele 2019-03-25 08:44:23 Re: Re: reloption to prevent VACUUM from truncating empty pages at the end of relation
Previous Message David Steele 2019-03-25 08:32:21 Re: Re: allow online change primary_conninfo