Re: [PATCH] Increase the maximum value track_activity_query_size

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Bruce Momjian <bruce(at)momjian(dot)us>
Cc: v(dot)makarov(at)postgrespro(dot)ru, pgsql-hackers(at)lists(dot)postgresql(dot)org
Subject: Re: [PATCH] Increase the maximum value track_activity_query_size
Date: 2019-12-19 15:59:27
Message-ID: 556.1576771167@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Good question. I am in favor of allowing a larger value if no one
> objects. I don't think adding the min/max is helpful.

I think there are pretty obvious performance and memory-consumption
penalties to very large track_activity_query_size values. Who exactly
are we really helping if we let them set it to huge values?

(wanders away wondering if we have suitable integer-overflow checks
in relevant code paths...)

regards, tom lane

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2019-12-19 16:02:48 Re: Read Uncommitted
Previous Message Tom Lane 2019-12-19 15:55:42 Re: [PATCH] Remove twice assignment with var pageop (nbtree.c).