Re: Change pg_cancel_*() to ignore current backend

On 5/20/15 8:47 AM, Tom Lane wrote:
> Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com> writes:
>> On 5/19/15 9:19 PM, Fabrízio de Royes Mello wrote:
>>> +1 to add a second parameter to current functions.
>
>> Instead of allow_own_pid, I went with skip_own_pid. I have the function
>> still returning true even when it skips it's own PID... that seems a bit
>> weird, but I think it's better than returning false. Unless someone
>> thinks it should return NULL, but I don't see that as any better either.
>
> The implementation would probably be considerably simpler if you treated
> these as separate functions at the SQL/C level, ie overload rather than
> try to treat the added parameter as having a default.

AFAICS that's just a minor change to what I'm doing in
catalog/system_view.sql and nothing else, so I'm not seeing the win.
What am I missing?

Now that we have default parameters my preference is to use them if for
no other reason than reduce bloat in \df...

BTW, is there a reason we're putting function SQL in that file other
than it was a convenient place?
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com