From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
---|---|
To: | CharSyam <charsyam(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: Typo patch |
Date: | 2015-05-20 16:49:29 |
Message-ID: | 555CBB19.8090206@iki.fi |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 05/20/2015 07:29 PM, CharSyam wrote:
> Hi,
>
> I changed typos error. and attached patch for this.
> Thanks you.
>
> I only changed comments only
Thanks, committed. Except for this one:
--- src/backend/utils/sort/logtape.c
+++ src/backend/utils/sort/logtape.c
@@ -926,7 +926,7 @@ LogicalTapeBackspace(LogicalTapeSet *lts, int
tapenum, size_t size)
/*
* Seek to an arbitrary position in a logical tape.
*
- * *Only* a frozen-for-read tape can be seeked.
+ * *Only* a frozen-for-read tape can be sought.
*
* Return value is TRUE if seek successful, FALSE if there isn't that much
* data in the tape (in which case there's no state change).
It's true that the past tense of "seek" is "sought", but it feels a bit
weird to me in this context. This is a comment on a function called
"<blah blah>seek", and it's not clear to me that it should conjugate
like the normal "seek" verb.
- Heikki
From | Date | Subject | |
---|---|---|---|
Next Message | CharSyam | 2015-05-20 16:53:20 | Re: Typo patch |
Previous Message | Robert Haas | 2015-05-20 16:46:02 | Re: Problems with question marks in operators (JDBC, ECPG, ...) |