Re: pgsql: Allow on-the-fly capture of DDL event details

From: Andrew Dunstan <andrew(at)dunslane(dot)net>
To: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Allow on-the-fly capture of DDL event details
Date: 2015-05-12 12:54:14
Message-ID: 5551F7F6.2010607@dunslane.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers


On 05/12/2015 12:05 AM, Alvaro Herrera wrote:
> Michael Paquier wrote:
>> On Tue, May 12, 2015 at 11:43 AM, Michael Paquier
>> <michael(dot)paquier(at)gmail(dot)com> wrote:
>>> On Tue, May 12, 2015 at 11:37 AM, Alvaro Herrera
>>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>>> Michael Paquier wrote:
>>>>> On Tue, May 12, 2015 at 7:16 AM, Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> wrote:
>>>> Not sure what's the real fix here ..
>>> I think that you should then use MODULE_big instead of MODULES, and
>>> set OBJS as "test_dll_parser.o $(WIN32RES)".
>> Taking it back, listing explicitly the list of tests in the Makefile's
>> REGRESS works just fine. Patch attached.
> Sure. I want to avoid doing that, though: we may want to generate a
> schedule based on src/test/regress/serial_schedule, so that newly added
> tests to the regular suite are automatically considered by this module.
>

If you want to do that you will need to make some special adjustment in
the MSVC build system. You can't use $(srcdir) in REGRESS and expect the
MSVC builds not to break otherwise. We don't do that anywhere else AFAICT.

cheers

andrew

In response to

Browse pgsql-committers by date

  From Date Subject
Next Message Andrew Dunstan 2015-05-12 13:42:56 pgsql: Map basebackup tablespaces using a tablespace_map file
Previous Message Michael Paquier 2015-05-12 04:27:17 Re: pgsql: Allow on-the-fly capture of DDL event details