| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Takeshi Ideriha <iderihatakeshi(at)gmail(dot)com>, Peter Smith <smithpb2250(at)gmail(dot)com>, shveta malik <shveta(dot)malik(at)gmail(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org> |
| Subject: | Re: DOCS - CREATE PUBLICATION wording re 'ONLY' for partitioned tables. |
| Date: | 2026-10-22 09:20:10 |
| Message-ID: | 5551453C-B6E1-43B8-82C9-90BAE58C970E@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Oct 22, 2026, at 16:14, Fujii Masao <masao(dot)fujii(at)gmail(dot)com> wrote:
>
> On Tue, Oct 20, 2026 at 2:20 PM Takeshi Ideriha
> <iderihatakeshi(at)gmail(dot)com> wrote:
>> Thank you for addressing my suggestion. V3 looks good to me. I also
>> believe the same wording works.
>
> Thanks for updating the patch!
>
> + For a partitioned table, <literal>ONLY</literal> and <literal>*</literal>
> + have no effect: its partitions are always implicitly considered part of
> + the publication, so they do not need to be added explicitly.
>
> In ALTER PUBLICATION, "table_name" also applies to DROP and EXCEPT,
> so seems the original wording needs to account for those cases.
> How about:
>
> For a partitioned table, <literal>ONLY</literal> and <literal>*</literal>
> have no effect. When a partitioned table is included in a publication,
> its partitions are implicitly included as well and need not be added
> explicitly. For tables specified in <literal>EXCEPT</literal>, see the
> description of
> <link linkend="sql-createpublication-params-for-except-table"><literal>EXCEPT</literal></link>
> in <xref linkend="sql-createpublication"/>.
>
I like the first part of your suggested change, “when a partitioned table is included in a publication”, but I don't think we need to mention EXCEPT separately. Maybe we could just replace “not be added explicitly” with “not be included explicitly”? I think that should cover the EXCEPT case as well.
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Ilia Evdokimov | 2026-10-22 09:44:37 | Incorrect selectivity estimates for NOT on nullable boolean columns |
| Previous Message | Fujii Masao | 2026-10-22 09:18:02 | Re: PG19: two RI fast-path issues found while testing the batching revert |