Re: Broken --dry-run mode in pg_rewind

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Vladimir Borodin <root(at)simply(dot)name>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Broken --dry-run mode in pg_rewind
Date: 2015-05-08 12:34:19
Message-ID: 554CAD4B.7080502@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 05/08/2015 03:25 PM, Vladimir Borodin wrote:
> Hi all.
>
> Seems, that pg_rewind does not account --dry-run option properly. A simple fix
> for that is attached.

No, the --dry-run takes effect later. It performs all the actions it
normally would, including reading files from the source, except for
actually writing anything in the target. See the dry-run checks in
file_ops.c

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-05-08 12:39:10 Re: Broken --dry-run mode in pg_rewind
Previous Message Vladimir Borodin 2015-05-08 12:25:54 Broken --dry-run mode in pg_rewind