Re: BRIN range operator class

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: emre(at)hasegeli(dot)com
Cc: PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: BRIN range operator class
Date: 2015-05-05 00:51:38
Views: Raw Message | Whole Thread | Download mbox | Resend email
Lists: pgsql-hackers

From my point of view as a reviewer this patch set is very close to
being committable.

= brin-inclusion-v06-01-sql-level-support-functions.patch

This patch looks good.

= brin-inclusion-v06-02-strategy-numbers.patch

This patch looks good, but shouldn't it be merged with 07?

= brin-inclusion-v06-03-remove-assert-checking.patch

As you wrote earlier this is needed because the new range indexes would
violate the asserts. I think it is fine to remove the assertion.

= brin-inclusion-v06-04-fix-brin-deform-tuple.patch

This patch looks good and can be committed separately.

= brin-inclusion-v06-05-box-vs-point-operators.patch

This patch looks good and can be committed separately.

= brin-inclusion-v06-06-inclusion-opclasses.patch

- "operator classes store the union of the values in the indexed column"
is not technically true. It stores something which covers all of the values.
- Missing space in "except box and point*/".
- Otherwise looks good.

= brin-inclusion-v06-07-remove-minmax-amprocs.patch

Shouldn't this be merged with 02? Otherwise it looks good.

Andreas Karlsson

In response to


Browse pgsql-hackers by date

  From Date Subject
Next Message Stefan Keller 2015-05-05 01:40:11 Re: BRIN range operator class
Previous Message Stephen Frost 2015-05-05 00:37:19 Re: Auditing extension for PostgreSQL (Take 2)