Re: [HACKERS] SAVEPOINT syntax again

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: Oliver Jowett <oliver(at)opencloud(dot)com>
Cc: Patches <pgsql-patches(at)postgresql(dot)org>
Subject: Re: [HACKERS] SAVEPOINT syntax again
Date: 2004-08-12 17:49:59
Message-ID: 5543.1092332999@sss.pgh.pa.us
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers pgsql-patches

Oliver Jowett <oliver(at)opencloud(dot)com> writes:
> Here's an updated patch that supports the syntax you suggest. I kept the
> error messages, doc examples and regression tests using RELEASE
> SAVEPOINT in full to follow the standard.

As long as we're tweaking syntax to agree with the spec ...

I notice that both SQL99 and SQL2003 require commas between the options
for START TRANSACTION and SET TRANSACTION, whereas our current grammar
has no commas. I propose that we fix the grammar to allow optional
commas there, to support the standard syntax without breaking existing
apps.

Unless someone objects, I'll add this to Oliver's patch and commit.

regards, tom lane

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Kenneth Marshall 2004-08-12 18:25:17 Re: Re: We have got a serious problem with pg_clog/WAL synchronization
Previous Message Tom Lane 2004-08-12 17:13:46 Re: Re: We have got a serious problem with pg_clog/WAL synchronization

Browse pgsql-patches by date

  From Date Subject
Next Message Bruce Momjian 2004-08-12 17:50:33 Re: [PATCHES] Win32 Event log
Previous Message Andrew Dunstan 2004-08-12 17:15:02 Re: [PATCHES] Win32 Event log