| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Steve Singer <steve(at)ssinger(dot)info>, Alex Shulgin <ash(at)commandprompt(dot)com> |
| Cc: | Craig Ringer <craig(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: [PATCH] HINT: pg_hba.conf changed since last config reload |
| Date: | 2015-04-30 20:43:13 |
| Message-ID: | 554293E1.8060103@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 12/20/14 12:11 PM, Steve Singer wrote:
> On 12/19/2014 10:41 AM, Alex Shulgin wrote:
>> I don't think so. The scenario this patch relies on assumes that the
>> DBA will remember to look in the log if something goes wrong, and in
>> your case there would be a message like the following:
>>
>> WARNING: pg_hba.conf not reloaded
>>
>> So an extra hint about file timestamp is unneeded.
>
> That makes sense to me.
> I haven't found any new issues with this patch.
> I think it is ready for a committer.
There were later comments in this thread that disagreed with the extra
logging infrastructure, and there were some questions about whether it
should only log on failed authentication attempts. Altogether, still
some open questions about behavior and implementation approach. So I'm
marking this as returned with feedback for now.
Personally, I think this could be a useful feature, but it needs more
fine-tuning.
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-04-30 20:57:19 | Re: PATCH: adaptive ndistinct estimator v4 |
| Previous Message | Robert Haas | 2015-04-30 20:27:08 | Re: pgbench -f and vacuum |