From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Robert Haas <robertmhaas(at)gmail(dot)com> |
Cc: | Petr Jelinek <petr(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: mogrify and indent features for jsonb |
Date: | 2015-04-29 19:09:51 |
Message-ID: | 55412C7F.10507@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
On 04/29/2015 01:19 PM, Robert Haas wrote:
> On Mon, Apr 27, 2015 at 6:41 PM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>> There's one exception I, at least, have to this rule, namely when there's a
>> corresponding compound if or else. I personally find this unaesthetic to put
>> it mildly:
>>
>> if (condition)
>> statement;
>> else
>> {
>> block of statements;
>> }
> Hmm, I don't dislike that style. If somebody submitted a patch with
> braces around the lone statement, I would remove them before
> committing.
>
> <ducks>
>
It's a matter of taste, but I find things a lot easier to understand
when they are symmetrical. Thus I like all the branches of an "if" to be
either in a block or not, and I like braces to line up either
horizontally or vertically. Perhaps this reflects my history, where I
wrote huge amounts of Ada and other non-C-like languages, well before I
ever wrote lots of C or C-ish languages.
Another case where I think putting a single statement in a block makes
sense is where the condition of the "if" spreads across more than one
line. This works particularly well with our BSD style brace placement.
cheers
andrew
From | Date | Subject | |
---|---|---|---|
Next Message | Stephen Frost | 2015-04-29 19:13:27 | Re: INSERT ... ON CONFLICT syntax issues |
Previous Message | Robert Haas | 2015-04-29 19:09:13 | Re: INSERT ... ON CONFLICT syntax issues |