Re: pgsql: Add transforms feature

On 04/27/2015 08:21 AM, Peter Eisentraut wrote:
> On 4/27/15 2:23 AM, Michael Paquier wrote:
>> On Mon, Apr 27, 2015 at 1:36 AM, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> wrote:
>>> Peter Eisentraut <peter_e(at)gmx(dot)net> writes:
>>>> Add transforms feature
>>> I don't know why this patch is fooling around with compile/link flags,
>>> but it's broken at least prairiedog and some of the Windows critters.
>> It breaks as well on all the Windows machines using MS or VC toolchains...
> The failure on bowerbird (Windows msvc) is because the build system
> needs to be told to add additional include directories to the compilation.
>
> The failure on frogmouth (Windows gcc) is because of some conflict with
> perl headers. I must have missed a trick that was already in use for
> plperl.
>
> Help in either case, but especially the first one, is welcome.
>
>

I haven't looked at the MSVC case yet, but one thing I notice on jacana
(Windows 8.1, gcc) is that the order of include directories is
different. When compiling plperl, the perl CORE directory is last in the
include list, whereas for compiling hstore_plperl it's second from the
beginning. I have no idea yet if that makes any difference, but would
not be at all surprised it if did. We should probably be mimicking what
the plperl makefile does.

Incidentally, I notice that hstore_plperl.c doesn't have a copyright
notice nor a single comment, not even at the start of the public
functions. That seems less than good.

cheers

andrew