| From: | Peter Eisentraut <peter_e(at)gmx(dot)net> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net> |
| Cc: | Noah Misch <noah(at)leadboat(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: forward vs backward slashes in msvc build code |
| Date: | 2015-04-27 12:25:11 |
| Message-ID: | 553E2AA7.1040409@gmx.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 4/27/15 2:09 AM, Michael Paquier wrote:
> 2) I noticed that VC builds do not like *at all* file paths with
> forward slashes, perhaps it could be possible to use a Condition like
> hasForwardSlashes but it seems safer to simply enforce the file paths
> to use backslashes in the vcproj files. That's inconsistent with the
> vcxproj files, but it works and Mkvcbuild.pm works as before.
> 3) I found why chkpass was needed as a dependency with libpgport and
> libpgcommon, actually crypt.c needs to be listed as a unique file, so
> it needs a fake entry in vcproj and vcxproj files.
> All those things are corrected in the patch attached, tested with both
> MS and VC.
What's the difference between MS and VC?
If VC doesn't accept forward slashes, doesn't that invalidate the
premise of this patch? Is it worth attempting to maintain it?
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andrew Dunstan | 2015-04-27 12:28:34 | Re: collate.linux.utf8 test coverage |
| Previous Message | Peter Eisentraut | 2015-04-27 12:21:09 | Re: pgsql: Add transforms feature |