Re: forward vs backward slashes in msvc build code

From: Peter Eisentraut <peter_e(at)gmx(dot)net>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Cc: Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: forward vs backward slashes in msvc build code
Date: 2015-04-25 12:58:56
Message-ID: 553B8F90.3040208@gmx.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 4/24/15 12:22 AM, Michael Paquier wrote:
> On Fri, Mar 13, 2015 at 6:04 PM, Michael Paquier
> <michael(dot)paquier(at)gmail(dot)com> wrote:
>> On Fri, Mar 13, 2015 at 6:20 AM, Alvaro Herrera wrote:
>>> Peter Eisentraut wrote:
>>>> This is contrib/chkpass not finding the crypt symbol, which is
>>>> presumably in some library. But I can't see how it would normally find
>>>> it, without my patch.
>>>
>>> It seems crypt is provided by libpgport. So chkpass should be mentioned
>>> in @contrib_uselibpgport, but isn't. Maybe the fix is just to add it
>>> there?
>>
>> I had a closer look at this patch, and yes indeed, the problem was
>> exactly that. Now honestly I cannot understand why this dependency
>> with libpgport was not necessary before... In any case, attached is a
>> patch rebased on HEAD that builds correctly with MSVC.
>
> Now that the stuff related to the move from contrib/ to src/bin/,
> modulescheck and tmp_install has been committed, shouldn't we give a
> new shot at this patch? Attached is a rebased version.

done

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-04-25 13:49:22 Re: adding more information about process(es) cpu and memory usage
Previous Message Fabrízio de Royes Mello 2015-04-25 12:05:54 Re: Can pg_dump make use of CURRENT/SESSION_USER