| From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
|---|---|
| To: | Bruce Momjian <bruce(at)momjian(dot)us> |
| Cc: | Martijn van Oosterhout <kleptog(at)svana(dot)org>, Andrew Dunstan <andrew(at)dunslane(dot)net>, pgsql-hackers(at)postgresql(dot)org, Kris Jurka <books(at)ejurka(dot)com> |
| Subject: | Re: src/tools/pginclude considered harmful (was Re: [PATCHES] |
| Date: | 2006-07-14 23:06:20 |
| Message-ID: | 5539.1152918380@sss.pgh.pa.us |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers pgsql-patches |
Bruce Momjian <bruce(at)momjian(dot)us> writes:
> Tom Lane wrote:
>> BTW, one of the remaining holes in pgrminclude is that it compiles with
>> -fsyntax-only, which apparently causes it to fail to detect some errors
>> of significance --- I assume that's how it managed to foul up lmgr.c,
>> inet_net_ntop.c, etc.
> But I do run a full compile and regression before commit, so that should
> have caught it even if pgrminclude didn't.
Doesn't catch warnings (unless you add -Werror during the build, which
will have problems with the remaining expected warnings...)
regards, tom lane
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-07-14 23:13:19 | Re: src/tools/pginclude considered harmful (was Re: |
| Previous Message | Hiroshi Saito | 2006-07-14 22:37:01 | Re: [PATCHES] c.h is the problem of msvc. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2006-07-14 23:13:19 | Re: src/tools/pginclude considered harmful (was Re: |
| Previous Message | Hiroshi Saito | 2006-07-14 22:37:01 | Re: [PATCHES] c.h is the problem of msvc. |