Re: Supporting src/test/modules in MSVC builds

On 04/16/2015 02:46 AM, Michael Paquier wrote:
> Hi all,
>
> As mentioned previously
> (CAB7nPqSCphafxS2RzeB-FBccjqiKnQXJhLoZtkggiM1MF5Xv4A(at)mail(dot)gmail(dot)com),
> attached are patches to add support for src/test/modules in MSVC
> builds, modules whose tests are not supported since they have been
> moved from contrib/:
> - 0001 adds support for the build portion.
> - 0002 adds support for the installation. I arrived at the conclusion
> that those modules should be installed by default, because
> contribcheck relies on the fact that tests should be run on a server
> already running, and modulescheck should do the same IMO.
> - 0003 adds a new target modulescheck in vcregress.
>
> Patches 0001 and 0003 are based on some previous work from Alvaro,
> that I modified slightly after testing them. Note that this split is
> done to test each step on the build farm for safety.
> Regards,
>

Thanks for doing this. It looks good, and if you've tested it I'm
satisfied. I suggest that we apply patches 1 and 2 immediately. AUIU
they don't require any changes to the buildfarm, as the MSVC build
process will automatically build and install it with these changes. Then
if all goes well we can apply the third patch and I'll fix the buildfarm
client for the forthcoming release to run the tests on MSVC builds.
Nothing will break in the meantime - the tests just won't get run until
the new client version is deployed.

cheers

andrew