Re: pgsql: Don't archive bogus recycled or preallocated files after timelin

From: Heikki Linnakangas <hlinnaka(at)iki(dot)fi>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: pgsql-committers(at)postgresql(dot)org
Subject: Re: pgsql: Don't archive bogus recycled or preallocated files after timelin
Date: 2015-04-14 06:38:28
Message-ID: 552CB5E4.8050207@iki.fi
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

On 04/14/2015 02:24 AM, Tom Lane wrote:
> Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> writes:
>> To fix, whenever we switch to a new timeline, scan the data directory for
>> WAL segments on the old timeline, but with a higher segment number, and
>> remove them.
>
> Wait a minute. Didn't you just break PITR scenarios? The *entire point*
> of the multiple-timeline mechanism is that you can start a new WAL history
> from a point in the past without destroying WAL history after that point
> on the old timeline.

It deletes the files belonging to other timelines from pg_xlog only. The
WAL archive is not touched.

- Heikki

In response to

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-04-14 14:09:28 pgsql: Reorganize our CRC source files again.
Previous Message Tom Lane 2015-04-13 23:24:15 Re: pgsql: Don't archive bogus recycled or preallocated files after timelin