Re: pg_regress writes into source tree

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Andrew Dunstan <andrew(at)dunslane(dot)net>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: pg_regress writes into source tree
Date: 2015-04-08 01:28:39
Message-ID: 55248447.1060201@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/13/15 11:20 PM, Michael Paquier wrote:
> On Sat, Feb 14, 2015 at 6:24 AM, Andrew Dunstan <andrew(at)dunslane(dot)net> wrote:
>>
>> On 12/18/2014 06:05 PM, Andrew Dunstan wrote:
>>>
>>>
>>> On 12/18/2014 03:02 AM, Michael Paquier wrote:
>>>>
>>>> On Fri, Dec 12, 2014 at 10:45 PM, Alvaro Herrera
>>>> <alvherre(at)2ndquadrant(dot)com> wrote:
>>>>
>>>>> Another thing in that patch was that I had to add the sql/ directory to
>>>>> the source tree, but other than that .gitignore file it was empty.
>>>>> Maybe pg_regress should create the sql/ directory in the build dir if it
>>>>> doesn't exist. This is only a problem if a pg_regress suite only runs
>>>>> stuff from input/, because otherwise the sql/ dir already exists in the
>>>>> source.
>>>>
>>>> +1 for having pg_regress create the sql/ directory when it does not
>>>> exist. Current behavior is annoying when modules having only tests in
>>>> input/...
>>>
>>>
>>>
>>>
>>> That seems like a separate issue. I think Peter should commit his patch
>>> and backpatch it immediately, and we can deal with the missing sql directory
>>> when someone sends in a patch.
>>
>>
>>
>> What's happened on this?
>
> Nothing has been committed, and as far as I understood this patch
> could have been simply pushed...

Just so this doesn't get lost... did something make it into a CommitFest
on this?
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-04-08 01:32:10 Re: Tuple visibility within a single XID
Previous Message Alvaro Herrera 2015-04-08 01:21:27 Re: New error code to track unsupported contexts