| From: | Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com> |
|---|---|
| To: | Michael Paquier <michael(at)paquier(dot)xyz> |
| Cc: | Peter Eisentraut <peter(at)eisentraut(dot)org>, Euler Taveira <euler(at)eulerto(dot)com>, Aleksander Alekseev <aleksander(at)tigerdata(dot)com>, pgsql-hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: change default default_toast_compression to lz4? |
| Date: | 2026-03-04 04:52:02 |
| Message-ID: | 55248210-E76F-4062-889B-D07B82EAAB9A@gmail.com |
| Views: | Whole Thread | Raw Message | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
> On Mar 4, 2026, at 12:09, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
> On Fri, Feb 27, 2026 at 10:10:20AM +0900, Michael Paquier wrote:
>> Ah, right. This is what we have done for ICU in fcb21b3acdcb. While
>> --with-lz4 is still allowed for backward-compatibility, we show only
>> --without-icu in the output of configure --help. Reflecting the
>> documentation to show up the same contents as --help makes sense.
>
> It would have been a waste to not see this change happening, so I have
> looked a bit more in depth at it. You are right that we should remove
> the reference to --with-lz4, but it seems to me that this should apply
> to all the references of the switch we have in the docs. The change
> in meson.build was not necessary. Another thing not yet included was
> the mandatory autoreconf. With all that done, applied.
>
> Now, let's see how much this breaks the buildfarm.. Because things
> will break. I'll send a poke to the buildfarm mailing list.
> --
> Michael
Hi Michael,
As you have pushed this patch, could you please take a look at [1] that fixes an edge-case bug of in astreamer for the lz4 decompressor.
[1] https://www.postgresql.org/message-id/0594CC79-1544-45DD-8AA4-26270DE777A7%40gmail.com
Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2026-03-04 05:05:14 | Re: change default default_toast_compression to lz4? |
| Previous Message | Amul Sul | 2026-03-04 04:50:08 | pg_combinebackup: incorrect size of VM fork after combine |