| From: | Jesper Pedersen <jesper(dot)pedersen(at)redhat(dot)com> |
|---|---|
| To: | Robert Haas <robertmhaas(at)gmail(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | Ashutosh Sharma <ashu(dot)coek88(at)gmail(dot)com>, Mithun Cy <mithun(dot)cy(at)enterprisedb(dot)com>, Amit Kapila <amit(dot)kapila16(at)gmail(dot)com>, Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>, Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, Jeff Janes <jeff(dot)janes(at)gmail(dot)com>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: pageinspect: Hash index support |
| Date: | 2017-02-03 16:49:09 |
| Message-ID: | 551edf28-6133-d714-aa07-e04b6848b7f5@redhat.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/03/2017 11:41 AM, Jesper Pedersen wrote:
>>> contrib/pageinspect actually seems to lack *any* infrastructure
>>> for sharing functions across modules. It's time to remedy that.
>>> I propose inventing "pageinspect.h" to hold commonly visible
>>> declarations, and moving get_page_from_raw() into rawpage.c,
>>> which seems like a reasonably natural home for it. (Alternatively,
>>> we could invent a pageinspect.c file to hold utility functions,
>>> but that might be overkill.)
>>
>> No objections.
>>
>
> Attached is v1 of this w/ verify_hash_page() using get_page_from_raw().
>
> Sorry for all the problems.
>
Disregard, as Tom has committed a fix.
Best regards,
Jesper
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2017-02-03 16:49:59 | Re: \if, \elseif, \else, \endif (was Re: PSQL commands: \quit_if, \quit_unless) |
| Previous Message | Jesper Pedersen | 2017-02-03 16:41:05 | Re: pageinspect: Hash index support |