Re: Remove traces of long in dynahash.c

From: Chao Li <li(dot)evan(dot)chao(at)gmail(dot)com>
To: Michael Paquier <michael(at)paquier(dot)xyz>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Postgres hackers <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Remove traces of long in dynahash.c
Date: 2025-08-20 23:43:49
Message-ID: 5513A5B1-090C-4B05-8981-C8224AB78C45@gmail.com
Views: Whole Thread | Raw Message | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi Michael,

> On Aug 21, 2025, at 07:07, Michael Paquier <michael(at)paquier(dot)xyz> wrote:
>
>
> After sleeping on it, I am not sure what to do with these routines. I
> don't deny that more refactoring can be done. However, all that can
> also happen outside the long -> int64 switch I am suggesting.
>
> Any comments from others?
> --
> Michael

I don’t want to block you. Unless others have the same comment about naming, you can go ahead and move forward. I agree further refactoring can belong to a separate commit.

Best regards,
--
Chao Li (Evan)
HighGo Software Co., Ltd.
https://www.highgo.com/

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Mihail Nikalayeu 2025-08-20 23:44:00 Re: Adding REPACK [concurrently]
Previous Message Michael Paquier 2025-08-20 23:12:36 Re: VM corruption on standby