| From: | Heikki Linnakangas <hlinnaka(at)iki(dot)fi> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | Abhijit Menon-Sen <ams(at)2ndQuadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: What exactly is our CRC algorithm? |
| Date: | 2015-03-25 17:24:26 |
| Message-ID: | 5512EF4A.6000900@iki.fi |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/25/2015 07:20 PM, Andres Freund wrote:
> On 2015-03-25 19:18:51 +0200, Heikki Linnakangas wrote:
>> Or better yet, a direct configure test to check if the
>> intrinsic exists - that way we get to also use it on Intel compilers, which
>> I believe also has the same intrinsics.
>
> Maybe I'm missing something, but configure isn't run for msvc?
Good point. On MSVC, we use the pre-built pg_config.h.win32 file
instead. There are already a couple of cases like this in it:
/* Define to 1 if you have the `rint' function. */
#if (_MSC_VER >= 1800)
#define HAVE_RINT 1
#endif
I think we should do that for the CRC32 intrinsic too.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jim Nasby | 2015-03-25 17:52:39 | Re: proposal: plpgsql - Assert statement |
| Previous Message | Andres Freund | 2015-03-25 17:20:22 | Re: What exactly is our CRC algorithm? |