Re: PATCH: numeric timestamp in log_line_prefix

From: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>
To: Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com>, Fabien COELHO <fabien(dot)coelho(at)mines-paristech(dot)fr>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL Developers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: PATCH: numeric timestamp in log_line_prefix
Date: 2015-03-23 22:02:04
Message-ID: 55108D5C.8030706@BlueTreble.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 3/22/15 2:59 PM, Tomas Vondra wrote:
> On 22.3.2015 20:25, Fabien COELHO wrote:
>> >
>>>> >>>The proposed format is much simpler to manage in a script, and if you're
>>>> >>>interested in runtime, its formatting would be less expensive than %t
>>>> >>>and
>>>> >>>%m.
>>> >>
>>> >>Maybe, but do we really need two? How about just %M?
>> >
>> >I guess Tomas put 2 formats because there was 2 time formats to
>> >begin with, but truncating/rouding if someone really wants seconds is
>> >quite easy.
> Yes, that's why I added two - to reflect %t and %m. I'm OK with using
> just one of them - I don't really care for the milliseconds at this
> moment, but I'd probably choose that option.

I assume we're using milli instead of micro because that's what everyone
else does? It seems odd since we natively support microseconds, but I
guess if milliseconds is more normal for logging that's OK.

FWIW, I don't see a problem with both %T and %M (whatever M ends up
meaning), but I don't really care either way.
--
Jim Nasby, Data Architect, Blue Treble Consulting
Data in Trouble? Get it in Treble! http://BlueTreble.com

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tomas Vondra 2015-03-23 22:08:10 Re: logical column ordering
Previous Message Peter Geoghegan 2015-03-23 21:46:55 Re: Abbreviated keys for Numeric