| From: | Tomas Vondra <tomas(dot)vondra(at)2ndquadrant(dot)com> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: PATCH: numeric timestamp in log_line_prefix |
| Date: | 2015-03-22 18:42:49 |
| Message-ID: | 550F0D29.60208@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22.3.2015 08:14, David Rowley wrote:
> Hi Tomas,
>
> I just had a quick glance at this.
> Is there a reason you didn't include code to support the space padding
> for the new log_line_prefixes?
> The others support %<padding><char> in the prefix, to allow left or
> right alignment of the item.
Didn't realize that, will fix in the next version.
>
> Also, what's the reason for timestamp_str? Could you not just use
> appendStringInfo() and skip the temporary buffer?
Yeah, that's probably a good idea too.
>
> Regards
>
> David Rowley
--
Tomas Vondra http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Fabien COELHO | 2015-03-22 18:45:27 | Re: PATCH: numeric timestamp in log_line_prefix |
| Previous Message | Tomas Vondra | 2015-03-22 18:40:35 | Re: PATCH: numeric timestamp in log_line_prefix |