Re: patch : Allow toast tables to be moved to a different tablespace

From: Andreas Karlsson <andreas(at)proxel(dot)se>
To: Julien Tachoires <julmon(at)gmail(dot)com>, Alex Shulgin <ash(at)commandprompt(dot)com>
Cc: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Jaime Casanova <jaime(at)2ndquadrant(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: patch : Allow toast tables to be moved to a different tablespace
Date: 2015-03-21 12:56:34
Message-ID: 550D6A82.2070208@proxel.se
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 03/21/2015 01:19 PM, Julien Tachoires wrote:
>> I am confused by your fix. Wouldn't cleaner fix be to use
>> tbinfo->reltablespace rather than tbinfo->reltoasttablespace when
>> calling ArchiveEntry()?
>
> Yes, doing this that way is cleaner. Here is a new version including
> your fix. Thanks.

I am now satisfied with how the patch looks. Thanks for your work. I
will mark this as ready for committeer now but not expect any committer
to look at it until the commitfest starts.

--
Andreas Karlsson

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-03-21 13:00:42 Re: Re: [BUGS] BUG #11805: Missing SetServiceStatus call during service shutdown in pg_ctl (Windows only)
Previous Message Michael Paquier 2015-03-21 12:20:03 Re: printing table in asciidoc with psql