Re: ArchiveEntry optional arguments refactoring

From: Daniel Gustafsson <daniel(at)yesql(dot)se>
To: Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: Andres Freund <andres(at)anarazel(dot)de>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, Chapman Flack <chap(at)anastigmatix(dot)net>, Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: ArchiveEntry optional arguments refactoring
Date: 2019-02-01 10:05:34
Views: Raw Message | Whole Thread | Download mbox
Lists: pgsql-hackers

> On 24 Jan 2019, at 13:12, Dmitry Dolgov <9erthalion6(at)gmail(dot)com> wrote:

> Here is another version, where I accumulated all the suggestions:

Nothing sticks out during review and AFAICT all comments have been addressed.
Everything works as expected during (light) testing between master and an older

+1 on committing this, having spent a lot of time in this code I really
appreciate the improved readability.

cheers ./daniel

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message rajan 2019-02-01 10:35:03 where clause not working through psql command line client
Previous Message Alvaro Herrera 2019-02-01 10:01:19 Re: speeding up planning with partitions