| From: | Petr Jelinek <petr(at)2ndquadrant(dot)com> |
|---|---|
| To: | Andrew Dunstan <andrew(at)dunslane(dot)net>, Peter Geoghegan <pg(at)heroku(dot)com> |
| Cc: | Arne Scheffer <arne(dot)scheffer(at)uni-muenster(dot)de>, David G Johnston <david(dot)g(dot)johnston(at)gmail(dot)com>, Pg Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Add min and max execute statement time in pg_stat_statement |
| Date: | 2015-03-14 14:09:49 |
| Message-ID: | 5504412D.4070909@2ndquadrant.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 22/02/15 01:59, Petr Jelinek wrote:
> On 21/02/15 22:09, Andrew Dunstan wrote:
>>
>> On 02/16/2015 09:05 PM, Petr Jelinek wrote:
>>>
>>> I found one more issue with the 1.2--1.3 upgrade script, the DROP
>>> FUNCTION pg_stat_statements(); should be DROP FUNCTION
>>> pg_stat_statements(bool); since in 1.2 the function identity has
>>> changed.
>>>
>>>
>>
>>
>> I think all the outstanding issues are fixed in this patch.
>>
>
> I think PGSS_FILE_HEADER should be also updated, otherwise it's good.
>
>
I see you marked this as 'needs review', I am marking it as 'ready for
committer' as it looks good to me.
Just don't forget to update the PGSS_FILE_HEADER while committing (I
think that one can be threated same way as catversion, ie be updated by
committer and not in patch submission).
--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andreas Karlsson | 2015-03-14 15:05:52 | Re: patch : Allow toast tables to be moved to a different tablespace |
| Previous Message | Amit Kapila | 2015-03-14 12:31:51 | Re: pg_rewind in contrib |