Re: mogrify and indent features for jsonb

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Andrew Dunstan <andrew(at)dunslane(dot)net>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Dmitry Dolgov <9erthalion6(at)gmail(dot)com>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: mogrify and indent features for jsonb
Date: 2015-03-13 16:30:57
Message-ID: 550310C1.8000708@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox
Thread:
Lists: pgsql-hackers

On 01/03/15 16:49, Andrew Dunstan wrote:
>
> On 03/01/2015 05:03 AM, Petr Jelinek wrote:
>> On 23/02/15 18:15, Dmitry Dolgov wrote:
>>> Hi, Petr, thanks for the review.
>>>
>>> >>> I think it would be better if the ident printing didn't put the
>>> start of array ([) and start of dictionary ({) on separate line
>>> Did you mean this?
>>>
>>> [
>>> {
>>> "a": 1,
>>> "b": 2
>>> }
>>> ]
>>>
>>> I tried to verify this in several ways (http://jsonprettyprint.com/,
>>> "JSON.stringify", "json.too" from python), and I always get this result
>>> (new line after ([) and ({) ).
>>
>> No, I mean new lines before the ([) and ({) - try pretty printing
>> something like '{"a":["b", "c"], "d": {"e":"f"}}' using that tool you
>> pasted and see what your patch outputs to see what I mean.
>>
>>
>
>
> Please try this patch and see if it's doing what you want.
>

Yes, this produces output that looks like what javascript/python produce.

(the other stuff I commented about, mainly the h_atoi is still unfixed
though)

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Robert Haas 2015-03-13 16:39:02 Re: pg_dump quietly ignore missing tables - is it bug?
Previous Message Ronan Dunklau 2015-03-13 16:20:09 Re: Regarding pg_stat_statements