Re: monitoring.sgml missing tag

From: Erik Rijkers <er(at)xs4all(dot)nl>
To: Andres Freund <andres(at)anarazel(dot)de>
Cc: pgsql-hackers(at)postgresql(dot)org
Subject: Re: monitoring.sgml missing tag
Date: 2017-04-07 21:00:01
Message-ID: 54f2049ba4e47c9120bcfb3fadff79c0@xs4all.nl
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2017-04-07 22:50, Andres Freund wrote:
> On 2017-04-07 22:47:55 +0200, Erik Rijkers wrote:
>> monitoring.sgml has one </row> tag missing
>
> Is that actually an issue? SGML allows skipping certain close tags, and
> IIRC row is one them. We'll probably move to xml at some point not too
> far away, but I don't think it makes much sense to fix these
> one-by-one.

Well, I have only used make oldhtml before now so maybe I am doing
something wrong.

I try to run make html.

First, I got this (just showing first few of a 75x repeat):

$ time ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml;
make html; )
osx -D . -D . -x lower postgres.sgml >postgres.xml.tmp
osx:monitoring.sgml:1278:12:E: document type does not allow element
"ROW" here
osx:monitoring.sgml:1282:12:E: document type does not allow element
"ROW" here
osx:monitoring.sgml:1286:12:E: document type does not allow element
"ROW" here
...
osx:monitoring.sgml:1560:12:E: document type does not allow element
"ROW" here
osx:monitoring.sgml:1564:13:E: end tag for "ROW" omitted, but OMITTAG NO
was specified
osx:monitoring.sgml:1275:8: start tag was here
make: *** [postgres.xml] Error 1

After closing that tag with </row> , make html still fails:

$ time ( cd /home/aardvark/pg_stuff/pg_sandbox/pgsql.HEAD/doc/src/sgml;
make html; )
osx -D . -D . -x lower postgres.sgml >postgres.xml.tmp
'/opt/perl-5.24/bin/perl' -p -e
's/\[(aacute|acirc|aelig|agrave|amp|aring|atilde|auml|bull|copy|eacute|egrave|gt|iacute|lt|mdash|nbsp|ntilde|oacute|ocirc|oslash|ouml|pi|quot|scaron|uuml)
*\]/\&\1;/gi;' -e '$_ .= qq{<!DOCTYPE book PUBLIC "-//OASIS//DTD DocBook
XML V4.2//EN"
"http://www.oasis-open.org/docbook/xml/4.2/docbookx.dtd">\n} if $. ==
1;' <postgres.xml.tmp > postgres.xml
rm postgres.xml.tmp
xmllint --noout --valid postgres.xml
xsltproc --stringparam pg.version '10devel' stylesheet.xsl postgres.xml
runtime error: file stylesheet-html-common.xsl line 41 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 41 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
runtime error: file stylesheet-html-common.xsl line 30 element
call-template
The called template 'id.attribute' was not found.
no result for postgres.xml
make: *** [html-stamp] Error 9

real 4m23.641s
user 4m22.304s
sys 0m0.914s

Any hints welcome...

thanks

$ cat /etc/redhat-release
CentOS release 6.6 (Final)

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Andres Freund 2017-04-07 21:11:47 Re: monitoring.sgml missing tag
Previous Message Thomas Munro 2017-04-07 20:57:12 Re: valgrind errors around dsa.c