Re: Support tab completion for upper character inputs in psql

From: Peter Eisentraut <peter(dot)eisentraut(at)enterprisedb(dot)com>
To: "tanghy(dot)fnst(at)fujitsu(dot)com" <tanghy(dot)fnst(at)fujitsu(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>, Laurenz Albe <laurenz(dot)albe(at)cybertec(dot)at>
Cc: "smithpb2250(at)gmail(dot)com" <smithpb2250(at)gmail(dot)com>, "david(dot)zhang(at)highgo(dot)ca" <david(dot)zhang(at)highgo(dot)ca>, "pgsql-hackers(at)lists(dot)postgresql(dot)org" <pgsql-hackers(at)lists(dot)postgresql(dot)org>
Subject: Re: Support tab completion for upper character inputs in psql
Date: 2022-01-06 07:46:48
Message-ID: 54bd7839-f463-ef03-f2d2-ccb8184b9b27@enterprisedb.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 10.09.21 15:50, tanghy(dot)fnst(at)fujitsu(dot)com wrote:
>> (A test case for the enum case should be doable easily.)
> Test added.

The enum test is failing on *some* platforms:

t/010_tab_completion.pl .. 26/?
# Failed test 'complete enum values'
# at t/010_tab_completion.pl line 211.
# Actual output was "ALTER TYPE mytype1 RENAME VALUE '\a\r\n'BLUE'
'bLACK' 'green' \r\npostgres=# ALTER TYPE mytype1 RENAME VALUE '"
# Did not match "(?^:'bLACK' + 'BLUE' + 'green')"

So the ordering of the suggested completions is different. I don't know
offhand how that ordering is determined. Perhaps it's dependent on
locale, readline version, or operating system. In any case, we need to
figure this out to make this test stable.

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Pavel Stehule 2022-01-06 07:52:23 Re: pl/pgsql feature request: shorthand for argument and local variable references
Previous Message Dilip Kumar 2022-01-06 07:42:29 Re: Make relfile tombstone files conditional on WAL level