| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Josh Berkus <josh(at)agliodbs(dot)com>, Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
| Cc: | hlinnaka(at)iki(dot)fi, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Patch: raise default for max_wal_segments to 1GB |
| Date: | 2015-03-03 20:36:07 |
| Message-ID: | 54F61B37.8060105@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2015 02:59 PM, Josh Berkus wrote:
> On 03/03/2015 11:57 AM, Tom Lane wrote:
>> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>>> Do we want to remove unit comments from all settings which accept
>>> "MB,GB" or "ms,s,min"? There's more than a few. I'd be in favor of
>>> this, but seems like (a) it should be universal, and (b) its own patch.
>> Meh. Doing this strikes me as a serious documentation failure, since it
>> is no longer apparent what happens if you put in a unitless number.
> Well, you know my opinion about documentation in the pg.conf file.
> However, I'm not confident I'm in the majority there.
I think there's a difference between comments about the function of a
GUC and stating the units it's specified in. It's more than annoying to
have to go and look that up where it's not stated.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Robert Haas | 2015-03-03 20:43:02 | Re: add modulo (%) operator to pgbench |
| Previous Message | Eric Grinstein | 2015-03-03 20:30:44 | Re: Idea: GSoC - Query Rewrite with Materialized Views |