| From: | Gavin Flower <GavinFlower(at)archidevsys(dot)co(dot)nz> |
|---|---|
| To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, Josh Berkus <josh(at)agliodbs(dot)com> |
| Cc: | hlinnaka(at)iki(dot)fi, Andres Freund <andres(at)2ndquadrant(dot)com>, pgsql-hackers(at)postgresql(dot)org, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Patch: raise default for max_wal_segments to 1GB |
| Date: | 2015-03-03 20:10:34 |
| Message-ID: | 54F6153A.5040406@archidevsys.co.nz |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 04/03/15 08:57, Tom Lane wrote:
> Josh Berkus <josh(at)agliodbs(dot)com> writes:
>> Do we want to remove unit comments from all settings which accept
>> "MB,GB" or "ms,s,min"? There's more than a few. I'd be in favor of
>> this, but seems like (a) it should be universal, and (b) its own patch.
> Meh. Doing this strikes me as a serious documentation failure, since it
> is no longer apparent what happens if you put in a unitless number.
>
> Now, if we were to change the server so that it *refused* settings that
> didn't have a unit, that argument would become moot. But I'm not going
> to defend the castle against the villagers who will show up if you do
> that.
>
> regards, tom lane
>
>
How about introducing a 'strict' mode that does extra checking like that?
JavaScript and Perl, both have a 'strict' mode.
In strict mode you could insist on all quantities having units, and
possibly some additional sanity checking - without enraging the peasants!
Cheers,
Gavin
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Corey Huinker | 2015-03-03 20:22:52 | Re: Patch: raise default for max_wal_segments to 1GB |
| Previous Message | Josh Berkus | 2015-03-03 19:59:32 | Re: Patch: raise default for max_wal_segments to 1GB |