| From: | Josh Berkus <josh(at)agliodbs(dot)com> |
|---|---|
| To: | Fujii Masao <masao(dot)fujii(at)gmail(dot)com> |
| Cc: | Andres Freund <andres(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Petr Jelinek <petr(at)2ndquadrant(dot)com>, Venkata Balaji N <nag1010(at)gmail(dot)com>, Peter Eisentraut <peter_e(at)gmx(dot)net>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Subject: | Re: Patch: raise default for max_wal_segments to 1GB |
| Date: | 2015-03-03 19:04:30 |
| Message-ID: | 54F605BE.6050307@agliodbs.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 03/03/2015 02:12 AM, Fujii Masao wrote:
> On Tue, Mar 3, 2015 at 8:51 AM, Josh Berkus <josh(at)agliodbs(dot)com> wrote:
>> On 03/02/2015 03:43 PM, Andres Freund wrote:
>>> Hi,
>>>
>>> On 2015-03-02 15:40:27 -0800, Josh Berkus wrote:
>>>> ! #max_wal_size = 1GB # in logfile segments
>>>
>>> Independent of the rest of the changes, the "in logfile segments" bit
>>> should probably be changed.
>>
>> Point! Although I think it's fair to point out that that wasn't my
>> omission, but Heikki's.
>>
>> Version C, with that correction, attached.
>
> Minor comments:
>
> "The default settings are 5 minutes and 128 MB, respectively." in wal.sgml
> needs to be updated.
>
>
> int max_wal_size = 8; /* 128 MB */
>
> It's better to update the above code in xlog.c. That's not essential, though.
Attached is version D, which incorporates the above two changes, but NOT
a general unit comment cleanup of postgresql.conf, which needs to be an
entirely different patch.
--
Josh Berkus
PostgreSQL Experts Inc.
http://pgexperts.com
| Attachment | Content-Type | Size |
|---|---|---|
| max_wal_1gb_d.patch | text/x-patch | 4.1 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Josh Berkus | 2015-03-03 19:05:26 | Re: Patch: raise default for max_wal_segments to 1GB |
| Previous Message | Corey Huinker | 2015-03-03 18:58:42 | Re: Patch: raise default for max_wal_segments to 1GB |