Re: Auditing extension for PostgreSQL (Take 2)

From: David Steele <david(at)pgmasters(dot)net>
To: Stephen Frost <sfrost(at)snowman(dot)net>
Cc: pgsql-hackers(at)postgresql(dot)org, Abhijit Menon-Sen <ams(at)2ndquadrant(dot)com>
Subject: Re: Auditing extension for PostgreSQL (Take 2)
Date: 2015-02-24 16:22:41
Message-ID: 54ECA551.8060306@pgmasters.net
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 2/23/15 10:59 AM, David Steele wrote:
> On 2/17/15 10:34 AM, Stephen Frost wrote:
>> There seems to be a number of places which are 'pgaudit' and a bunch
>> that are 'pg_audit'. I'm guessing you were thinking 'pg_audit', but
>> it'd be good to clean up and make them all consistent.
>
> Fixed, though I still left the file name as pgaudit.sgml since all but
> one module follow that convention.

It turns out there are a few places where _ is not allowed. I've
reverted a few places to fix the doc build while maintaining the name as
pg_audit in the visible docs.

>> Perhaps I missed it, but it'd be good to point out that GUCs can be set
>> at various levels. I know we probably say that somewhere else, but it's
>> particularly relevant for this.

I added notes as suggested.

Patch v3 is attached.

--
- David Steele
david(at)pgmasters(dot)net

Attachment Content-Type Size
pg_audit-v3.patch text/plain 78.2 KB

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Tom Lane 2015-02-24 17:04:11 Re: Precedence of NOT LIKE, NOT BETWEEN, etc
Previous Message Andres Freund 2015-02-24 16:19:12 Re: Primary not sending to synchronous standby