xpath changes in the recent back branches

From: Marko Tiikkaja <marko(at)joh(dot)to>
To: Pgsql Hackers <pgsql-hackers(at)postgresql(dot)org>
Subject: xpath changes in the recent back branches
Date: 2015-02-19 10:53:37
Message-ID: 54E5C0B1.6040001@joh.to
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

Hi,

Commit 79af9a1d2668c9edc8171f03c39e7fed571eeb98 changed xpath handling
with regard to namespaces, and it seems to be fixing an actual issue.
However, it was also backpatched to all branches despite it breaking for
example code like this:

do $$
declare
_x xml;
begin
_x := (xpath('/x:Foo/x:Bar', xml '<Foo
xmlns="teh:urn"><Bar><Baz>1</Baz><Bat>2</Bat></Bar></Foo>',
array[['x','teh:urn']]))[1];
raise notice '%', xpath('/Bar/Baz/text()', _x);
raise notice '%', xpath('/Bar/Bat/text()', _x);
end
$$;

The problem is that there's no way to write the code like this in such a
way that it would work on both versions. If I add the namespace, it's
broken on 9.1.14. Without it it's broken on 9.1.15.

I'm now thinking of adding a workaround which strips namespaces, but
that doesn't seem to be easy to do, even with PL/Perl. Is there a
better workaround here that I'm not seeing?

I'm not sure how changing behavior like this in a minor release was
considered acceptable.

.m

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Heikki Linnakangas 2015-02-19 13:21:34 Re: INSERT ... ON CONFLICT {UPDATE | IGNORE} 2.0
Previous Message Fujii Masao 2015-02-19 10:22:21 Re: pg_basebackup may fail to send feedbacks.