| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)2ndQuadrant(dot)com> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: Simplify sleeping while reading/writing from client |
| Date: | 2015-02-12 14:23:14 |
| Message-ID: | 54DCB752.7080504@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/06/2015 11:50 AM, Andres Freund wrote:
> On 2015-02-05 16:45:50 +0200, Heikki Linnakangas wrote:
>> I propose the attached, which pulls all the wait-retry logic up to
>> secure_read() and secure_write(). This makes the code a lot more
>> understandable.
>
> Generally a good idea. Especially if we get more ssl implementations.
>
> But I think it'll make the already broken renegotiation handling even
> worse. Because now we're always entering do_handshake in nonblocking
> mode (essentially).
Good point. In the other thread, we concluded that the
SSL_do_handshake() call isn't really needed anyway, so attached are two
patches: 1. remove the SSL_do_handshake() calls, and 2. the previous
patch, to simplify the waiting logic.
- Heikki
| Attachment | Content-Type | Size |
|---|---|---|
| 0001-Simplify-the-way-OpenSSL-renegotiation-is-initiated-.patch | application/x-patch | 1.8 KB |
| 0002-Simplify-waiting-logic-in-reading-from-writing-to-cl.patch | application/x-patch | 10.6 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Marco Nenciarini | 2015-02-12 14:31:38 | Re: pg_check_dir comments and implementation mismatch |
| Previous Message | Andres Freund | 2015-02-12 13:58:32 | Re: Logical decoding document |