| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Michael Paquier <michael(dot)paquier(at)gmail(dot)com> |
| Cc: | PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: Small memory leak in execute.c of ECPG driver |
| Date: | 2015-02-04 12:59:55 |
| Message-ID: | 54D217CB.2090105@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 02/03/2015 02:45 PM, Michael Paquier wrote:
> On Tue, Feb 3, 2015 at 5:35 PM, Heikki Linnakangas
> <hlinnakangas(at)vmware(dot)com> wrote:
>> >I think there are more similar leaks nearby. After the first hunk, there's
>> >another if-check with "return false" that also leaks mallocedval. Right
>> >after the two other hunks, if the ecpg_realloc fails, we again leak
>> >mallocedval.
> Yes, I found some extra ones by re-reading the code again with newcopy
> (2) as well as mallocedval (1) as you mentioned.
Committed, along with more fixes for leaks on ecpg_realloc failures.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Stephen Frost | 2015-02-04 13:08:37 | Re: pg_dump's aborted transactions |
| Previous Message | Michael Paquier | 2015-02-04 12:00:08 | Re: Unnecessary pointer-NULL checks in pgp-pgsql.c |