| From: | Heikki Linnakangas <hlinnakangas(at)vmware(dot)com> |
|---|---|
| To: | Andres Freund <andres(at)anarazel(dot)de> |
| Cc: | PostgreSQL-development <pgsql-hackers(at)postgreSQL(dot)org> |
| Subject: | Re: [COMMITTERS] pgsql: Process 'die' interrupts while reading/writing from the client s |
| Date: | 2015-02-03 22:47:03 |
| Message-ID: | 54D14FE7.5070601@vmware.com |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers pgsql-hackers |
On 02/03/2015 11:51 PM, Andres Freund wrote:
> + * This is called just after low-level writes. That might be after the read
> + * finished successfully, or it was interrupted via interrupt. 'blocked' tells
> + * us whether the
Looks like you forgot to complete that sentence before pushing...
Also, nightjar is unhappy with this:
TRAP: FailedAssertion("!(InterruptHoldoffCount == 0 && CritSectionCount
== 0)", File:
"/pgbuild/root/HEAD/pgsql.build/../pgsql/src/backend/tcop/postgres.c",
Line: 574)
I think that assertion in ProcessClientWriteInterrupt() should be simply
removed. ProcessClientWriteInterrupt() copes just fine, i.e. does
nothing, if we're in a critical section or interrupts are held.
- Heikki
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-02-03 22:57:28 | pgsql: Remove ill-conceived Assertion in ProcessClientWriteInterrupt(). |
| Previous Message | Andres Freund | 2015-02-03 22:28:20 | pgsql: Remove remnants of ImmediateInterruptOK handling. |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2015-02-03 23:08:32 | Re: Proposal : REINDEX xxx VERBOSE |
| Previous Message | Jim Nasby | 2015-02-03 22:31:29 | Re: [GENERAL] 4B row limit for CLOB tables |