Re: Missing markup in pg_receivexlog.sgml

From: Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>
To: Michael Paquier <michael(dot)paquier(at)gmail(dot)com>, PostgreSQL mailing lists <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: Missing markup in pg_receivexlog.sgml
Date: 2015-02-03 07:25:35
Message-ID: 54D077EF.2070103@vmware.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 02/03/2015 05:59 AM, Michael Paquier wrote:
> Hi all,
>
> Per $subject, I noticed that a markup was missing in the description
> of the option --synchronous.

> + Issue <command>sync</> commands as soon as there is WAL data which has
> + not been flushed yet. Also status packets are sent back to the server
> + just after WAL data is flushed whatever <literal>--status-interval</>
> + is set to.

Hmm. That would imply that pg_receivexlog calls /bin/sync. "sync
command" was confusing before, but putting it in <command> tags makes it
even more so.

I think that should be rewritten:

Flush the WAL data to disk immediately after it's being received. Also
send a status packet back to the server immediately after flushing,
regardless of <literal>--status-interval</>

- Heikki

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Michael Paquier 2015-02-03 07:28:10 Unlikely-to-happen crash in ecpg driver caused by NULL-pointer check not done
Previous Message Michael Paquier 2015-02-03 06:58:56 Small memory leak in execute.c of ECPG driver