| From: | Andreas Karlsson <andreas(at)proxel(dot)se> |
|---|---|
| To: | David Rowley <dgrowleyml(at)gmail(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com> |
| Cc: | Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>, Andres Freund <andres(at)2ndquadrant(dot)com> |
| Subject: | Re: Using 128-bit integers for sum, avg and statistics aggregates |
| Date: | 2015-01-22 23:40:51 |
| Message-ID: | 54C18A83.1070003@proxel.se |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
A new version of the patch is attached, which changes the following:
- Changed from using __int128_t to __int128.
- Actually compiles and runs code in configure to see that int128 works.
- No longer tests for __uint128_t.
- Updated pg_config.h.win32
- Renamed some things from int12 to int128, there are still some places
with int16 which I am not sure what to do with.
A remaining issue is what estimate we should pick for the size of the
aggregate state. This patch uses the size of the int128 version for the
estimate, but I have no strong opinions on which we should use.
--
Andreas Karlsson
| Attachment | Content-Type | Size |
|---|---|---|
| int128-agg-v5.patch | text/x-patch | 34.0 KB |
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Bruce Momjian | 2015-01-22 23:43:31 | Re: pg_upgrade and rsync |
| Previous Message | Peter Geoghegan | 2015-01-22 23:28:39 | Re: Back-branch update releases scheduled |