From: | Marco Nenciarini <marco(dot)nenciarini(at)2ndquadrant(dot)it> |
---|---|
To: | Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org> |
Subject: | Re: [RFC] LSN Map |
Date: | 2015-01-13 11:22:24 |
Message-ID: | 54B4FFF0.2060600@2ndquadrant.it |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-hackers |
Il 08/01/15 20:18, Jim Nasby ha scritto:
> On 1/7/15, 3:50 AM, Marco Nenciarini wrote:
>> The current implementation tracks only heap LSN. It currently does not
>> track any kind of indexes, but this can be easily added later.
>
> Would it make sense to do this at a buffer level, instead of at the heap
> level? That means it would handle both heap and indexes.
> I don't know if LSN is visible that far down though.
Where exactly you are thinking to handle it?
>
> Also, this pattern is repeated several times; it would be good to put it
> in it's own function:
> + lsnmap_pin(reln, blkno, &lmbuffer);
> + lsnmap_set(reln, blkno, lmbuffer, lsn);
> + ReleaseBuffer(lmbuffer);
Right.
Regards,
Marco
--
Marco Nenciarini - 2ndQuadrant Italy
PostgreSQL Training, Services and Support
marco(dot)nenciarini(at)2ndQuadrant(dot)it | www.2ndQuadrant.it
From | Date | Subject | |
---|---|---|---|
Next Message | John Gorman | 2015-01-13 11:25:10 | Re: Parallel Seq Scan |
Previous Message | David Rowley | 2015-01-13 11:20:49 | Re: Removing INNER JOINs |