| From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
|---|---|
| To: | Andres Freund <andres(at)2ndquadrant(dot)com> |
| Cc: | David Fetter <david(at)fetter(dot)org>, Heikki Linnakangas <hlinnakangas(at)vmware(dot)com>, Albe Laurenz <laurenz(dot)albe(at)wien(dot)gv(dot)at>, PG Hackers <pgsql-hackers(at)postgresql(dot)org> |
| Subject: | Re: POLA violation with \c service= |
| Date: | 2015-01-10 14:49:52 |
| Message-ID: | 54B13C10.1030601@dunslane.net |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-hackers |
On 01/10/2015 09:32 AM, Andres Freund wrote:
> On 2015-01-10 09:16:07 -0500, Andrew Dunstan wrote:
>> +static const char uri_designator[] = "postgresql://";
>> +static const char short_uri_designator[] = "postgres://";
>>
>> These declarations in common.h would cause a separate instance of these
>> pieces of storage to occur in every object file where the .h file had been
>> #included. In general, you should not expect to see any static declarations
>> in .h files.
> Save static inline functions, that is.
>
Yeah, but not normally data items. (I did say "in general"). As a
general rule for novice C programmers I think my rule of thumb is
reasonable.
cheers
andrew
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Andres Freund | 2015-01-10 14:53:24 | Re: POLA violation with \c service= |
| Previous Message | Andres Freund | 2015-01-10 14:32:37 | Re: POLA violation with \c service= |