Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Jim Nasby <Jim(dot)Nasby(at)BlueTreble(dot)com>, Kouhei Kaigai <kaigai(at)ak(dot)jp(dot)nec(dot)com>, Robert Haas <robertmhaas(at)gmail(dot)com>
Cc: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>, "pgsql-hackers(at)postgreSQL(dot)org" <pgsql-hackers(at)postgresql(dot)org>, Shigeru Hanada <shigeru(dot)hanada(at)gmail(dot)com>
Subject: Re: Custom/Foreign-Join-APIs (Re: [v9.5] Custom Plan API)
Date: 2015-01-06 23:24:17
Message-ID: 54AC6EA1.6010706@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 07/01/15 00:05, Jim Nasby wrote:
> On 1/6/15, 8:17 AM, Kouhei Kaigai wrote:
>> The attached patch is newer revision of custom-/foreign-join
>> interface.
>
> Shouldn't instances of
>
> scan_relid > 0
>
> be
>
> scan_relid != InvalidOid
>

Ideally, they should be OidIsValid(scan_relid)

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

In response to

Responses

Browse pgsql-hackers by date

  From Date Subject
Next Message Jim Nasby 2015-01-06 23:33:46 Re: Patch to add functionality to specify ORDER BY in CREATE FUNCTION for SRFs
Previous Message Peter Geoghegan 2015-01-06 23:21:39 Re: Possible typo in create_policy.sgml