Re: event trigger pg_dump fix

From: Petr Jelinek <petr(at)2ndquadrant(dot)com>
To: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
Cc: PostgreSQL-development <pgsql-hackers(at)postgresql(dot)org>
Subject: Re: event trigger pg_dump fix
Date: 2015-01-06 00:40:52
Message-ID: 54AB2F14.4060803@2ndquadrant.com
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-hackers

On 06/01/15 01:02, Tom Lane wrote:
> Petr Jelinek <petr(at)2ndquadrant(dot)com> writes:
>> Attached is fix for
>> http://www.postgresql.org/message-id/1420492505.23613.15.camel@bloodnok.com
>
>> It was dumping comment with NULL owner while the function expects
>> empty string for objects without owner (there is pg_strdup down the
>> line).
>
> This isn't right either: event triggers do have owners.
>

Bah, of course, stupid me.

--
Petr Jelinek http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services

Attachment Content-Type Size
pg_dump_evt_tigger_20150106.patch text/x-diff 486 bytes

In response to

Browse pgsql-hackers by date

  From Date Subject
Next Message Peter Eisentraut 2015-01-06 01:43:12 Re: Turning recovery.conf into GUCs
Previous Message Tom Lane 2015-01-06 00:02:40 Re: event trigger pg_dump fix