From: | Andrew Dunstan <andrew(at)dunslane(dot)net> |
---|---|
To: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
Cc: | pgsql-committers(at)postgresql(dot)org |
Subject: | Re: pgsql: Fix documentation of argument type of json_agg and jsonb_agg |
Date: | 2014-12-22 23:10:14 |
Message-ID: | 5498A4D6.8060107@dunslane.net |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
On 12/22/2014 02:34 PM, Tom Lane wrote:
> Andrew Dunstan <andrew(at)dunslane(dot)net> writes:
>> Fix documentation of argument type of json_agg and jsonb_agg
>> json_agg was originally designed to aggregate records. However, it soon
>> became clear that it is useful for aggregating all kinds of values and
>> that's what we have on 9.3 and 9.4, and in head for it and jsonb_agg.
>> The documentation suggested otherwise, so this fixes it.
> Claiming that the argument type is "expression" is not a fix. I don't
> mind using that terminology in the first table column, but the second
> column is supposed to be the truth not handwaving.
>
> The actual declaration of the argument type is "anyelement", and I think
> we use that to document other such functions.
>
>
Oh, I thought I had seen "expression" there. It looks like we're using
"any" elsewhere, so I'll use that. While I'm at it I'll remove the quote
marks around the arguments to json_object_agg().
From | Date | Subject | |
---|---|---|---|
Next Message | Andrew Dunstan | 2014-12-22 23:31:07 | pgsql: Further tidy up on json aggregate documentation |
Previous Message | Tom Lane | 2014-12-22 19:34:22 | Re: pgsql: Fix documentation of argument type of json_agg and jsonb_agg |